Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 846013002: Use rowgroup and columgroup properties to expose table headers. (Closed)

Created:
5 years, 11 months ago by k.czech
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use rowgroup and columgroup properties to expose table headers. Update current implementation so that rowgroup and columngroup properties are used when exposing table headers. BUG=448042, 435081 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188370

Patch Set 1 #

Patch Set 2 : Changed some text labels in test. #

Patch Set 3 : Updated expectation result file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -3 lines) Patch
M LayoutTests/accessibility/table-header-column-row.html View 1 1 chunk +32 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/table-header-column-row-expected.txt View 1 2 2 chunks +48 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableCell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableCell.cpp View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
k.czech
5 years, 11 months ago (2015-01-12 15:43:00 UTC) #2
dmazzoni
lgtm
5 years, 11 months ago (2015-01-13 22:41:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846013002/40001
5 years, 11 months ago (2015-01-13 22:42:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/46050)
5 years, 11 months ago (2015-01-14 00:54:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846013002/40001
5 years, 11 months ago (2015-01-14 09:02:41 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 09:45:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188370

Powered by Google App Engine
This is Rietveld 408576698