Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 845993003: DevTools: NetworkPanel: reenable clicking on "expand timeline" triangles. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/Source/devtools/front_end/network/NetworkDataGridNode.js b/Source/devtools/front_end/network/NetworkDataGridNode.js
index 08ec4bc013e087499eded811238f559158a69c4a..74670f2f6a0a065856b0bd9c5e69ba1a96193970 100644
--- a/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -394,7 +394,7 @@ WebInspector.NetworkDataGridNode.prototype = {
this._expandTimelineButton = this._timelineCell.createChild("div", "network-expand-timeline-button");
this._expandTimelineButton.createChild("div", "network-expand-timeline-glyph");
this._expandTimelineButton.title = WebInspector.UIString("Show full timeline");
- this._expandTimelineButton.addEventListener("click", this._onExpandTimeline.bind(this));
+ this._expandTimelineButton.addEventListener("mousedown", this._onExpandTimeline.bind(this));
} else if (!show && this._expandTimelineButton) {
this._expandTimelineButton.remove();
this._expandTimelineButton = null;
@@ -404,6 +404,7 @@ WebInspector.NetworkDataGridNode.prototype = {
_onExpandTimeline: function(event)
{
this._parentView.expandTimeline();
+ event.consume();
},
_updateTimingGraph: function()
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/DataGrid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698