[New Tab Page] Change the mechanism to intercept online NTP errors

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index d4d08514e567a66cd9a41dd4d43f1568ba594715..262321fa3d445e0a8b943d8439f2c2da4cfeaff0 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -77,6 +77,8 @@
 #include "chrome/browser/ui/blocked_content/blocked_window_params.h"
 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
+#include "chrome/browser/ui/search/new_tab_page_interceptor_service.h"
+#include "chrome/browser/ui/search/new_tab_page_interceptor_service_factory.h"
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
 #include "chrome/browser/ui/tab_contents/chrome_web_contents_view_delegate.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
@@ -981,6 +983,10 @@ ChromeContentBrowserClient::CreateRequestContext(
     content::ProtocolHandlerMap* protocol_handlers,
     content::URLRequestInterceptorScopedVector request_interceptors) {
   Profile* profile = Profile::FromBrowserContext(browser_context);
+  NewTabPageInterceptorService* service =
+      NewTabPageInterceptorServiceFactory::GetForProfile(profile);
+  if (service)
+    request_interceptors.push_back(service->CreateInterceptor().release());

[mmenke, 2015/01/16 22:04:16]

Should we really make one of these for incognito?

[Mathieu, 2015/01/22 19:21:58]

Are you saying we should? Currently we are not creating the interceptor in
incognito. It's not the same NTP.

[kmadhusu, 2015/01/22 20:06:30]

Incognito mode doesn't use an online ntp. We don't need to intercept those NTP
requests.

[mmenke, 2015/01/22 20:53:50]

Right...I missed the face that in
NewTabPageInterceptorServiceFactory::GetForProfile, we weren't creating a
service for incognito.  Had been thinking that were were making one for
incognito, which seemed like a bad idea.

   return profile->CreateRequestContext(protocol_handlers,
                                        request_interceptors.Pass());
 }