Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3117)

Unified Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 845973005: [New Tab Page] Change the mechanism to intercept online NTP errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved to profile_io_data Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper_unittest.cc
diff --git a/chrome/browser/ui/search/search_tab_helper_unittest.cc b/chrome/browser/ui/search/search_tab_helper_unittest.cc
index 0264ae2118037290355e275194633a6cae08ef2a..06066a5a486faa1965501b3cd6ca76c271f8f847 100644
--- a/chrome/browser/ui/search/search_tab_helper_unittest.cc
+++ b/chrome/browser/ui/search/search_tab_helper_unittest.cc
@@ -350,68 +350,6 @@ class SearchTabHelperWindowTest : public BrowserWithTestWindowTest {
}
};
-TEST_F(SearchTabHelperWindowTest, OnProvisionalLoadFailRedirectNTPToLocal) {
- AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
- content::WebContents* contents =
- browser()->tab_strip_model()->GetWebContentsAt(0);
- content::NavigationController* controller = &contents->GetController();
-
- SearchTabHelper* search_tab_helper =
- SearchTabHelper::FromWebContents(contents);
- ASSERT_NE(static_cast<SearchTabHelper*>(NULL), search_tab_helper);
-
- // A failed provisional load of a cacheable NTP should be redirected to local
- // NTP.
- const GURL cacheableNTPURL = chrome::GetNewTabPageURL(profile());
- search_tab_helper->DidFailProvisionalLoad(
- contents->GetMainFrame(), cacheableNTPURL, 1, base::string16());
- CommitPendingLoad(controller);
- EXPECT_EQ(GURL(chrome::kChromeSearchLocalNtpUrl),
- controller->GetLastCommittedEntry()->GetURL());
-}
-
-TEST_F(SearchTabHelperWindowTest, OnProvisionalLoadFailDontRedirectIfAborted) {
- AddTab(browser(), GURL("chrome://blank"));
- content::WebContents* contents =
- browser()->tab_strip_model()->GetWebContentsAt(0);
- content::NavigationController* controller = &contents->GetController();
-
- SearchTabHelper* search_tab_helper =
- SearchTabHelper::FromWebContents(contents);
- ASSERT_NE(static_cast<SearchTabHelper*>(NULL), search_tab_helper);
-
- // A failed provisional load of a cacheable NTP should be redirected to local
- // NTP.
- const GURL cacheableNTPURL = chrome::GetNewTabPageURL(profile());
- search_tab_helper->DidFailProvisionalLoad(contents->GetMainFrame(),
- cacheableNTPURL,
- net::ERR_ABORTED,
- base::string16());
- CommitPendingLoad(controller);
- EXPECT_EQ(GURL("chrome://blank"),
- controller->GetLastCommittedEntry()->GetURL());
-}
-
-TEST_F(SearchTabHelperWindowTest, OnProvisionalLoadFailDontRedirectNonNTP) {
- AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
- content::WebContents* contents =
- browser()->tab_strip_model()->GetWebContentsAt(0);
- content::NavigationController* controller = &contents->GetController();
-
- SearchTabHelper* search_tab_helper =
- SearchTabHelper::FromWebContents(contents);
- ASSERT_NE(static_cast<SearchTabHelper*>(NULL), search_tab_helper);
-
- // Any other web page shouldn't be redirected when provisional load fails.
- search_tab_helper->DidFailProvisionalLoad(contents->GetMainFrame(),
- GURL("http://www.example.com"),
- 1,
- base::string16());
- CommitPendingLoad(controller);
- EXPECT_NE(GURL(chrome::kChromeSearchLocalNtpUrl),
- controller->GetLastCommittedEntry()->GetURL());
-}
-
class SearchTabHelperPrerenderTest : public InstantUnitTestBase {
public:
~SearchTabHelperPrerenderTest() override {}
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698