Embed custom script into the snapshot.

Embed custom script into the snapshot.

R=vogelheim@chromium.org

Committed: https://crrev.com/39cd762c6c1675304dc9a3ba9637ac405a6eb211
Cr-Commit-Position: refs/heads/master@{#26029}

[vogelheim, 2015-01-12 13:50:44]

lgtm

The changes in snapshot-common.cc look unrelated to the custom script. I'm fine
with the changes, but just an fyi in case that wasn't intentional.

https://codereview.chromium.org/845973003/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/845973003/diff/1/tools/gyp/v8.gyp#newcode33
tools/gyp/v8.gyp:33: 'embed_script%': "",
BUILD.gn probably wants to know about embed_script, too.

(I think BUILD.gn doesn't implement all build options yet; so I'm not sure if
that makes sense right now...)

[Yang, 2015-01-12 14:58:12]

On 2015/01/12 13:50:44, vogelheim wrote:
> lgtm
> 
> The changes in snapshot-common.cc look unrelated to the custom script. I'm
fine
> with the changes, but just an fyi in case that wasn't intentional.

Fully intentional. I found that the profiling output did not contain context
deserialization, so I added them.

> 
> https://codereview.chromium.org/845973003/diff/1/tools/gyp/v8.gyp
> File tools/gyp/v8.gyp (right):
> 
> https://codereview.chromium.org/845973003/diff/1/tools/gyp/v8.gyp#newcode33
> tools/gyp/v8.gyp:33: 'embed_script%': "",
> BUILD.gn probably wants to know about embed_script, too.
> 
> (I think BUILD.gn doesn't implement all build options yet; so I'm not sure if
> that makes sense right now...)

The gyp option is simply for convenience for testing/debugging. Chrome is not
going to use it, and as long as we don't force feature parity, I'd leave it out
of BUILD.gn for now.

[Yang, 2015-01-12 14:58:15]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-01-12 14:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845973003/1

[commit-bot: I haz the power, 2015-01-12 15:26:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-12 15:26:43]

Patchset 1 (id:??) landed as
https://crrev.com/39cd762c6c1675304dc9a3ba9637ac405a6eb211
Cr-Commit-Position: refs/heads/master@{#26029}