Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 845923003: Add experimental v8 code cache options. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add experimental v8 code cache options. - heuristics-default: bail out to default behavior. - heuristics-default-mobile: as above, tuned for mobile. - recent: only cache recently compiled scripts. - recent-small: only cache small recently compiled scipts. R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:399580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188675

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M Source/bindings/core/v8/V8CacheOptions.h View 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 5 chunks +48 lines, -6 lines 1 comment Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
Yang
5 years, 11 months ago (2015-01-20 12:15:00 UTC) #1
vogelheim
lgtm Thanks, looks good!
5 years, 11 months ago (2015-01-20 12:25:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 13:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845923003/1
5 years, 11 months ago (2015-01-20 13:10:45 UTC) #5
marja
Did I understand this correctly? https://codereview.chromium.org/845923003/diff/1/Source/bindings/core/v8/V8ScriptRunner.cpp File Source/bindings/core/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/845923003/diff/1/Source/bindings/core/v8/V8ScriptRunner.cpp#newcode313 Source/bindings/core/v8/V8ScriptRunner.cpp:313: if (!isResourceHotForCaching(resource)) { So ...
5 years, 11 months ago (2015-01-20 13:14:33 UTC) #7
Yang
On 2015/01/20 13:14:33, marja wrote: > Did I understand this correctly? > > https://codereview.chromium.org/845923003/diff/1/Source/bindings/core/v8/V8ScriptRunner.cpp > ...
5 years, 11 months ago (2015-01-20 13:33:10 UTC) #8
marja
I'm worried that this wouldn't be hit often enough to actually put the data into ...
5 years, 11 months ago (2015-01-20 13:40:05 UTC) #9
Yang
On 2015/01/20 13:40:05, marja wrote: > I'm worried that this wouldn't be hit often enough ...
5 years, 11 months ago (2015-01-20 13:41:00 UTC) #10
marja
Ah right, then you don't need anything extra for this, nevermind :)
5 years, 11 months ago (2015-01-20 13:42:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/46948)
5 years, 11 months ago (2015-01-20 14:57:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845923003/1
5 years, 11 months ago (2015-01-20 14:59:13 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 15:47:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188675

Powered by Google App Engine
This is Rietveld 408576698