Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: sky/engine/core/rendering/RenderReplaced.cpp

Issue 845873004: Delete a bunch of paint invalidation rect computing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderReplaced.h ('k') | sky/engine/core/rendering/RenderText.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderReplaced.cpp
diff --git a/sky/engine/core/rendering/RenderReplaced.cpp b/sky/engine/core/rendering/RenderReplaced.cpp
index 3431bc133a5c70ff3b58db1345be083f52691027..c87cb33af0ccfbaca5f57f772dc154cf9890c4c6 100644
--- a/sky/engine/core/rendering/RenderReplaced.cpp
+++ b/sky/engine/core/rendering/RenderReplaced.cpp
@@ -479,11 +479,6 @@ void RenderReplaced::setSelectionState(SelectionState state)
if (!inlineBoxWrapper())
return;
- // We only include the space below the baseline in our layer's cached paint invalidation rect if the
- // image is selected. Since the selection state has changed update the rect.
- if (hasLayer())
- setPreviousPaintInvalidationRect(boundsRectForPaintInvalidation(containerForPaintInvalidation()));
-
if (canUpdateSelectionOnRootLineBoxes())
inlineBoxWrapper()->root().setHasSelectedChildren(isSelected());
}
@@ -511,13 +506,4 @@ bool RenderReplaced::isSelected() const
return false;
}
-LayoutRect RenderReplaced::clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const
-{
- // The selectionRect can project outside of the overflowRect, so take their union
- // for paint invalidation to avoid selection painting glitches.
- LayoutRect r = isSelected() ? localSelectionRect() : visualOverflowRect();
- mapRectToPaintInvalidationBacking(paintInvalidationContainer, r, paintInvalidationState);
- return r;
-}
-
}
« no previous file with comments | « sky/engine/core/rendering/RenderReplaced.h ('k') | sky/engine/core/rendering/RenderText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698