Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 845873004: Delete a bunch of paint invalidation rect computing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/RenderInline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index bba60cbee34147befdddde1aeed6ecb8462c75d5..7858a9e7374730d661d2d68fd9a533b898a138d5 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -988,25 +988,6 @@ bool RenderBox::paintInvalidationLayerRectsForImage(WrappedImagePtr image, const
return false;
}
-void RenderBox::clearPaintInvalidationState(const PaintInvalidationState& paintInvalidationState)
-{
- RenderBoxModelObject::clearPaintInvalidationState(paintInvalidationState);
-
- if (ScrollableArea* area = scrollableArea())
- area->resetScrollbarDamage();
-}
-
-#if ENABLE(ASSERT)
-bool RenderBox::paintInvalidationStateIsDirty() const
-{
- if (ScrollableArea* area = scrollableArea()) {
- if (area->hasVerticalBarDamage() || area->hasHorizontalBarDamage())
- return true;
- }
- return RenderBoxModelObject::paintInvalidationStateIsDirty();
-}
-#endif
-
bool RenderBox::pushContentsClip(PaintInfo& paintInfo, const LayoutPoint& accumulatedOffset, ContentsClipBehavior contentsClipBehavior)
{
if (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == PaintPhaseSelfOutline || paintInfo.phase == PaintPhaseMask)
@@ -1241,13 +1222,6 @@ void RenderBox::deleteLineBoxWrapper()
}
}
-LayoutRect RenderBox::clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const
-{
- LayoutRect r = visualOverflowRect();
- mapRectToPaintInvalidationBacking(paintInvalidationContainer, r, paintInvalidationState);
- return r;
-}
-
void RenderBox::mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect& rect, const PaintInvalidationState* paintInvalidationState) const
{
// The rect we compute at each step is shifted by our x/y offset in the parent container's coordinate space.
« no previous file with comments | « sky/engine/core/rendering/RenderBox.h ('k') | sky/engine/core/rendering/RenderInline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698