Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 845873004: Delete a bunch of paint invalidation rect computing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 RefPtr<FrameView> frameView = box().frameView(); 228 RefPtr<FrameView> frameView = box().frameView();
229 229
230 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScrollLayer", "data", InspectorScrollLayerEvent::data(&box())); 230 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScrollLayer", "data", InspectorScrollLayerEvent::data(&box()));
231 231
232 const RenderLayerModelObject* paintInvalidationContainer = box().containerFo rPaintInvalidation(); 232 const RenderLayerModelObject* paintInvalidationContainer = box().containerFo rPaintInvalidation();
233 233
234 // Update the positions of our child layers (if needed as only fixed layers should be impacted by a scroll). 234 // Update the positions of our child layers (if needed as only fixed layers should be impacted by a scroll).
235 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor. 235 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor.
236 if (!frameView->isInPerformLayout()) { 236 if (!frameView->isInPerformLayout()) {
237 // If we're in the middle of layout, we'll just update layers once layou t has finished. 237 // If we're in the middle of layout, we'll just update layers once layou t has finished.
238 // FIXME(sky): Do we still need this?
238 layer()->clipper().clearClipRectsIncludingDescendants(); 239 layer()->clipper().clearClipRectsIncludingDescendants();
239 box().setPreviousPaintInvalidationRect(box().boundsRectForPaintInvalidat ion(paintInvalidationContainer));
240 } 240 }
241 241
242 // The caret rect needs to be invalidated after scrolling 242 // The caret rect needs to be invalidated after scrolling
243 frame->selection().setCaretRectNeedsUpdate(); 243 frame->selection().setCaretRectNeedsUpdate();
244 244
245 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previou sPaintInvalidationRect()); 245 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previou sPaintInvalidationRect());
246 246
247 quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad( quadForFakeMouseMoveEvent); 247 quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad( quadForFakeMouseMoveEvent);
248 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 248 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
249 249
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild) 758 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild)
759 { 759 {
760 // We only want to track the topmost scroll child for scrollable areas with 760 // We only want to track the topmost scroll child for scrollable areas with
761 // overlay scrollbars. 761 // overlay scrollbars.
762 if (!hasOverlayScrollbars()) 762 if (!hasOverlayScrollbars())
763 return; 763 return;
764 m_nextTopmostScrollChild = scrollChild; 764 m_nextTopmostScrollChild = scrollChild;
765 } 765 }
766 766
767 } // namespace blink 767 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698