Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: sky/engine/core/rendering/RenderLayer.h

Issue 845873004: Delete a bunch of paint invalidation rect computing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderInline.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 bool needsCompositedScrolling() const { return m_scrollableArea && m_scrolla bleArea->needsCompositedScrolling(); } 228 bool needsCompositedScrolling() const { return m_scrollableArea && m_scrolla bleArea->needsCompositedScrolling(); }
229 229
230 // Computes the position of the given render object in the space of |paintIn validationContainer|. 230 // Computes the position of the given render object in the space of |paintIn validationContainer|.
231 // FIXME: invert the logic to have paint invalidation containers take care o f painting objects into them, rather than the reverse. 231 // FIXME: invert the logic to have paint invalidation containers take care o f painting objects into them, rather than the reverse.
232 // This will allow us to clean up this static method messiness. 232 // This will allow us to clean up this static method messiness.
233 static LayoutPoint positionFromPaintInvalidationContainer(const RenderObject *, const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalida tionState* = 0); 233 static LayoutPoint positionFromPaintInvalidationContainer(const RenderObject *, const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalida tionState* = 0);
234 234
235 // Adjusts the given rect (in the coordinate space of the RenderObject) to t he coordinate space of |paintInvalidationContainer|'s GraphicsLayer backing. 235 // Adjusts the given rect (in the coordinate space of the RenderObject) to t he coordinate space of |paintInvalidationContainer|'s GraphicsLayer backing.
236 static void mapRectToPaintInvalidationBacking(const RenderObject*, const Ren derLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalid ationState* = 0); 236 static void mapRectToPaintInvalidationBacking(const RenderObject*, const Ren derLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalid ationState* = 0);
237 237
238 // Computes the bounding paint invalidation rect for |renderObject|, in the coordinate space of |paintInvalidationContainer|'s GraphicsLayer backing.
239 static LayoutRect computePaintInvalidationRect(const RenderObject*, const Re nderLayer* paintInvalidationContainer, const PaintInvalidationState* = 0);
240
241 bool paintsWithTransform() const; 238 bool paintsWithTransform() const;
242 239
243 // Returns true if background phase is painted opaque in the given rect. 240 // Returns true if background phase is painted opaque in the given rect.
244 // The query rect is given in local coordinates. 241 // The query rect is given in local coordinates.
245 bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const; 242 bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const;
246 243
247 bool containsDirtyOverlayScrollbars() const { return m_containsDirtyOverlayS crollbars; } 244 bool containsDirtyOverlayScrollbars() const { return m_containsDirtyOverlayS crollbars; }
248 void setContainsDirtyOverlayScrollbars(bool dirtyScrollbars) { m_containsDir tyOverlayScrollbars = dirtyScrollbars; } 245 void setContainsDirtyOverlayScrollbars(bool dirtyScrollbars) { m_containsDir tyOverlayScrollbars = dirtyScrollbars; }
249 246
250 FilterOperations computeFilterOperations(const RenderStyle*); 247 FilterOperations computeFilterOperations(const RenderStyle*);
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 556
560 } // namespace blink 557 } // namespace blink
561 558
562 #ifndef NDEBUG 559 #ifndef NDEBUG
563 // Outside the WebCore namespace for ease of invocation from gdb. 560 // Outside the WebCore namespace for ease of invocation from gdb.
564 void showLayerTree(const blink::RenderLayer*); 561 void showLayerTree(const blink::RenderLayer*);
565 void showLayerTree(const blink::RenderObject*); 562 void showLayerTree(const blink::RenderObject*);
566 #endif 563 #endif
567 564
568 #endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYER_H_ 565 #endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYER_H_
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderInline.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698