Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: sky/engine/core/rendering/RenderBox.h

Issue 845873004: Delete a bunch of paint invalidation rect computing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 virtual InlineBox* createInlineBox(); 356 virtual InlineBox* createInlineBox();
357 void dirtyLineBoxes(bool fullLayout); 357 void dirtyLineBoxes(bool fullLayout);
358 358
359 // For inline replaced elements, this function returns the inline box that o wns us. Enables 359 // For inline replaced elements, this function returns the inline box that o wns us. Enables
360 // the replaced RenderObject to quickly determine what line it is contained on and to easily 360 // the replaced RenderObject to quickly determine what line it is contained on and to easily
361 // iterate over structures on the line. 361 // iterate over structures on the line.
362 InlineBox* inlineBoxWrapper() const { return m_rareData ? m_rareData->m_inli neBoxWrapper : 0; } 362 InlineBox* inlineBoxWrapper() const { return m_rareData ? m_rareData->m_inli neBoxWrapper : 0; }
363 void setInlineBoxWrapper(InlineBox*); 363 void setInlineBoxWrapper(InlineBox*);
364 void deleteLineBoxWrapper(); 364 void deleteLineBoxWrapper();
365 365
366 virtual LayoutRect clippedOverflowRectForPaintInvalidation(const RenderLayer ModelObject* paintInvalidationContainer, const PaintInvalidationState* = 0) cons t override;
367 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride; 366 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride;
368 367
369 LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType ) const; 368 LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType ) const;
370 369
371 virtual void updateLogicalWidth(); 370 virtual void updateLogicalWidth();
372 virtual void updateLogicalHeight(); 371 virtual void updateLogicalHeight();
373 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const; 372 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const;
374 373
375 void computeLogicalWidth(LogicalExtentComputedValues&) const; 374 void computeLogicalWidth(LogicalExtentComputedValues&) const;
376 375
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 virtual bool shouldComputeSizeAsReplaced() const { return isReplaced() && !i sInlineBlock(); } 526 virtual bool shouldComputeSizeAsReplaced() const { return isReplaced() && !i sInlineBlock(); }
528 527
529 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, const PaintInvalidationState* = 0) const override; 528 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, const PaintInvalidationState* = 0) const override;
530 529
531 void paintRootBoxFillLayers(const PaintInfo&); 530 void paintRootBoxFillLayers(const PaintInfo&);
532 531
533 RenderObject* splitAnonymousBoxesAroundChild(RenderObject* beforeChild); 532 RenderObject* splitAnonymousBoxesAroundChild(RenderObject* beforeChild);
534 533
535 void updateIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalH eight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; } 534 void updateIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalH eight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; }
536 535
537 virtual void clearPaintInvalidationState(const PaintInvalidationState&) over ride;
538 #if ENABLE(ASSERT)
539 virtual bool paintInvalidationStateIsDirty() const override;
540 #endif
541
542 private: 536 private:
543 void shrinkToFitWidth(const LayoutUnit availableSpace, const LayoutUnit logi calLeftValue, const LayoutUnit bordersPlusPadding, LogicalExtentComputedValues&) const; 537 void shrinkToFitWidth(const LayoutUnit availableSpace, const LayoutUnit logi calLeftValue, const LayoutUnit bordersPlusPadding, LogicalExtentComputedValues&) const;
544 538
545 // Returns true if we queued up a paint invalidation. 539 // Returns true if we queued up a paint invalidation.
546 bool paintInvalidationLayerRectsForImage(WrappedImagePtr, const FillLayer&, bool drawingBackground); 540 bool paintInvalidationLayerRectsForImage(WrappedImagePtr, const FillLayer&, bool drawingBackground);
547 541
548 bool skipContainingBlockForPercentHeightCalculation(const RenderBox* contain ingBlock) const; 542 bool skipContainingBlockForPercentHeightCalculation(const RenderBox* contain ingBlock) const;
549 543
550 LayoutUnit containingBlockLogicalWidthForPositioned(const RenderBoxModelObje ct* containingBlock) const; 544 LayoutUnit containingBlockLogicalWidthForPositioned(const RenderBoxModelObje ct* containingBlock) const;
551 LayoutUnit containingBlockLogicalHeightForPositioned(const RenderBoxModelObj ect* containingBlock) const; 545 LayoutUnit containingBlockLogicalHeightForPositioned(const RenderBoxModelObj ect* containingBlock) const;
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 if (UNLIKELY(inlineBoxWrapper() != 0)) 644 if (UNLIKELY(inlineBoxWrapper() != 0))
651 deleteLineBoxWrapper(); 645 deleteLineBoxWrapper();
652 } 646 }
653 647
654 ensureRareData().m_inlineBoxWrapper = boxWrapper; 648 ensureRareData().m_inlineBoxWrapper = boxWrapper;
655 } 649 }
656 650
657 } // namespace blink 651 } // namespace blink
658 652
659 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBOX_H_ 653 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBOX_H_
OLDNEW
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698