Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/rappor/rappor_service_unittest.cc

Issue 845863002: Add stricter tests for RapporService::LoadSecret (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/rappor_service.cc ('k') | components/rappor/test_rappor_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/rappor_service_unittest.cc
diff --git a/components/rappor/rappor_service_unittest.cc b/components/rappor/rappor_service_unittest.cc
index 1c88b9bcc0443eb274f3f910223a2b7608ec1f6f..7fedd6ef5e0b76d88800f493f98354d239fcac47 100644
--- a/components/rappor/rappor_service_unittest.cc
+++ b/components/rappor/rappor_service_unittest.cc
@@ -16,21 +16,6 @@
namespace rappor {
-TEST(RapporServiceTest, LoadCohort) {
- TestRapporService rappor_service;
- rappor_service.test_prefs()->SetInteger(prefs::kRapporCohortSeed, 1);
- EXPECT_EQ(1, rappor_service.LoadCohortForTesting());
-}
-
-TEST(RapporServiceTest, LoadSecret) {
- TestRapporService rappor_service;
- std::string secret = HmacByteVectorGenerator::GenerateEntropyInput();
- std::string secret_base64;
- base::Base64Encode(secret, &secret_base64);
- rappor_service.test_prefs()->SetString(prefs::kRapporSecret, secret_base64);
- EXPECT_EQ(secret, rappor_service.LoadSecretForTesting());
-}
-
TEST(RapporServiceTest, Update) {
TestRapporService rappor_service;
EXPECT_LT(base::TimeDelta(), rappor_service.next_rotation());
« no previous file with comments | « components/rappor/rappor_service.cc ('k') | components/rappor/test_rappor_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698