Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/io_thread.h

Issue 845843002: Clean up QUIC field trial parsing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-remove test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_IO_THREAD_H_ 5 #ifndef CHROME_BROWSER_IO_THREAD_H_
6 #define CHROME_BROWSER_IO_THREAD_H_ 6 #define CHROME_BROWSER_IO_THREAD_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 // performed by Chromium, and false if the OS should select the port. The OS 349 // performed by Chromium, and false if the OS should select the port. The OS
350 // option is used to prevent Windows from posting a security security warning 350 // option is used to prevent Windows from posting a security security warning
351 // dialog. 351 // dialog.
352 static bool ShouldEnableQuicPortSelection( 352 static bool ShouldEnableQuicPortSelection(
353 const base::CommandLine& command_line); 353 const base::CommandLine& command_line);
354 354
355 // Returns true if QUIC packet pacing should be negotiated during the 355 // Returns true if QUIC packet pacing should be negotiated during the
356 // QUIC handshake. 356 // QUIC handshake.
357 static bool ShouldEnableQuicPacing( 357 static bool ShouldEnableQuicPacing(
358 const base::CommandLine& command_line, 358 const base::CommandLine& command_line,
359 base::StringPiece quic_trial_group,
360 const VariationParameters& quic_trial_params); 359 const VariationParameters& quic_trial_params);
361 360
362 // Returns true if QUIC should always require handshake confirmation during 361 // Returns true if QUIC should always require handshake confirmation during
363 // the QUIC handshake. 362 // the QUIC handshake.
364 static bool ShouldQuicAlwaysRequireHandshakeConfirmation( 363 static bool ShouldQuicAlwaysRequireHandshakeConfirmation(
365 const VariationParameters& quic_trial_params); 364 const VariationParameters& quic_trial_params);
366 365
367 // Returns true if QUIC should disable connection pooling. 366 // Returns true if QUIC should disable connection pooling.
368 static bool ShouldQuicDisableConnectionPooling( 367 static bool ShouldQuicDisableConnectionPooling(
369 const VariationParameters& quic_trial_params); 368 const VariationParameters& quic_trial_params);
(...skipping 16 matching lines...) Expand all
386 385
387 // Returns true if QUIC's TruncatedConnectionIds should be enabled. 386 // Returns true if QUIC's TruncatedConnectionIds should be enabled.
388 static bool ShouldQuicEnableTruncatedConnectionIds( 387 static bool ShouldQuicEnableTruncatedConnectionIds(
389 const VariationParameters& quic_trial_params); 388 const VariationParameters& quic_trial_params);
390 389
391 // Returns the maximum length for QUIC packets, based on any flags in 390 // Returns the maximum length for QUIC packets, based on any flags in
392 // |command_line| or the field trial. Returns 0 if there is an error 391 // |command_line| or the field trial. Returns 0 if there is an error
393 // parsing any of the options, or if the default value should be used. 392 // parsing any of the options, or if the default value should be used.
394 static size_t GetQuicMaxPacketLength( 393 static size_t GetQuicMaxPacketLength(
395 const base::CommandLine& command_line, 394 const base::CommandLine& command_line,
396 base::StringPiece quic_trial_group,
397 const VariationParameters& quic_trial_params); 395 const VariationParameters& quic_trial_params);
398 396
399 // Returns the QUIC versions specified by any flags in |command_line| 397 // Returns the QUIC versions specified by any flags in |command_line|
400 // or |quic_trial_params|. 398 // or |quic_trial_params|.
401 static net::QuicVersion GetQuicVersion( 399 static net::QuicVersion GetQuicVersion(
402 const base::CommandLine& command_line, 400 const base::CommandLine& command_line,
403 const VariationParameters& quic_trial_params); 401 const VariationParameters& quic_trial_params);
404 402
405 // Returns the QUIC version specified by |quic_version| or 403 // Returns the QUIC version specified by |quic_version| or
406 // QUIC_VERSION_UNSUPPORTED if |quic_version| is invalid. 404 // QUIC_VERSION_UNSUPPORTED if |quic_version| is invalid.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 bool is_spdy_disabled_by_policy_; 471 bool is_spdy_disabled_by_policy_;
474 472
475 const base::TimeTicks creation_time_; 473 const base::TimeTicks creation_time_;
476 474
477 base::WeakPtrFactory<IOThread> weak_factory_; 475 base::WeakPtrFactory<IOThread> weak_factory_;
478 476
479 DISALLOW_COPY_AND_ASSIGN(IOThread); 477 DISALLOW_COPY_AND_ASSIGN(IOThread);
480 }; 478 };
481 479
482 #endif // CHROME_BROWSER_IO_THREAD_H_ 480 #endif // CHROME_BROWSER_IO_THREAD_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698