Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 845823002: PPAPI: Remove whitelist checks for PPB_VideoDecoder now that it's stable. (Closed)

Created:
5 years, 11 months ago by bbudge
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Remove whitelist checks for PPB_VideoDecoder now that it's stable. Whitelist checks prevent most clients from successfully creating a video decoder resource. Remove the whitelist checks now that the API is stable. BUG=447741 Committed: https://crrev.com/622cde4e3d0fce0d8b3cd2b4bb0207a472229ea5 Cr-Commit-Position: refs/heads/master@{#310911}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Total comments: 2

Patch Set 3 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 3 chunks +0 lines, -25 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (7 generated)
bbudge
5 years, 11 months ago (2015-01-09 21:39:51 UTC) #2
bbudge
+jam for content/ +thakis for chrome/
5 years, 11 months ago (2015-01-09 21:44:05 UTC) #4
dmichael (off chromium)
lgtm
5 years, 11 months ago (2015-01-09 21:49:41 UTC) #5
bbudge
+scottmg for chrome/ and content/
5 years, 11 months ago (2015-01-09 22:45:03 UTC) #7
scottmg
On 2015/01/09 22:45:03, bbudge wrote: > +scottmg for chrome/ and content/ Did you mean sky? ...
5 years, 11 months ago (2015-01-09 22:55:10 UTC) #8
bbudge
On 2015/01/09 22:55:10, scottmg wrote: > On 2015/01/09 22:45:03, bbudge wrote: > > +scottmg for ...
5 years, 11 months ago (2015-01-09 22:58:55 UTC) #9
bbudge
-jam +piman for content/
5 years, 11 months ago (2015-01-09 23:01:44 UTC) #11
bbudge
-piman +avi for content/
5 years, 11 months ago (2015-01-09 23:03:44 UTC) #13
Avi (use Gerrit)
LGTM https://codereview.chromium.org/845823002/diff/20001/content/renderer/pepper/content_renderer_pepper_host_factory.cc File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right): https://codereview.chromium.org/845823002/diff/20001/content/renderer/pepper/content_renderer_pepper_host_factory.cc#newcode164 content/renderer/pepper/content_renderer_pepper_host_factory.cc:164: } To match the style of the surrounding ...
5 years, 11 months ago (2015-01-09 23:07:08 UTC) #14
Nico
chrome lgtm Hooray!
5 years, 11 months ago (2015-01-09 23:08:05 UTC) #15
bbudge
https://codereview.chromium.org/845823002/diff/20001/content/renderer/pepper/content_renderer_pepper_host_factory.cc File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right): https://codereview.chromium.org/845823002/diff/20001/content/renderer/pepper/content_renderer_pepper_host_factory.cc#newcode164 content/renderer/pepper/content_renderer_pepper_host_factory.cc:164: } On 2015/01/09 23:07:08, Avi wrote: > To match ...
5 years, 11 months ago (2015-01-09 23:22:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845823002/40001
5 years, 11 months ago (2015-01-09 23:26:41 UTC) #18
piman
LGTM+++
5 years, 11 months ago (2015-01-09 23:32:52 UTC) #20
scottmg
(s/not/now/ in description if that doesn't require restarting cq, and lgtm for what that's worth)
5 years, 11 months ago (2015-01-09 23:36:21 UTC) #21
bbudge
Thanks for quick reviews everyone. Scott, if it's OK with you I'll fix the description ...
5 years, 11 months ago (2015-01-09 23:40:01 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-10 00:27:48 UTC) #23
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/622cde4e3d0fce0d8b3cd2b4bb0207a472229ea5 Cr-Commit-Position: refs/heads/master@{#310911}
5 years, 11 months ago (2015-01-10 00:28:39 UTC) #24
Nico
On 2015/01/09 23:40:01, bbudge wrote: > Thanks for quick reviews everyone. > Scott, if it's ...
5 years, 11 months ago (2015-01-10 00:43:47 UTC) #25
bbudge
5 years, 11 months ago (2015-01-10 00:45:47 UTC) #26
Message was sent while issue was closed.
On 2015/01/10 00:43:47, Nico wrote:
> On 2015/01/09 23:40:01, bbudge wrote:
> > Thanks for quick reviews everyone.
> > Scott, if it's OK with you I'll fix the description after landing.
> 
> FYI, you can just edit the cl description on rietveld and land. This should
take
> 2 seconds, won't invalidate try results, and makes sure that the fixed
> description appears in `git log`. So there never should be a reason to delay
cl
> description fixes.

Thanks, I didn't know that.

Powered by Google App Engine
This is Rietveld 408576698