Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845793005: choose better mip level (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : suppress known (better) gm changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
5 years, 11 months ago (2015-01-15 15:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845793005/20001
5 years, 11 months ago (2015-01-15 15:48:39 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-15 15:48:39 UTC) #5
robertphillips
lgtm
5 years, 11 months ago (2015-01-15 16:01:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/09544fcf9611be6efc0c38ab9d9a3f82181341fb
5 years, 11 months ago (2015-01-15 16:01:43 UTC) #7
reed1
5 years, 11 months ago (2015-01-15 16:24:04 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/812993008/ by reed@google.com.

The reason for reverting is: need more suppressions.

Powered by Google App Engine
This is Rietveld 408576698