Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 845793004: Update status files, replace "dartbug.com" with "Issue ". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 1bdf34e2b4d22e29967d886c11ae23140e30d9e3..1d1399042ec6595c60684f8bb33966f62a149e6d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1382,6 +1382,10 @@ class BrowserControllerTestOutcome extends CommandOutputImpl
if (_rawOutcome == Expectation.RUNTIME_ERROR) return Expectation.PASS;
return Expectation.MISSING_RUNTIME_ERROR;
}
+ if (testCase.hasCompileError) {
+ if (_rawOutcome == Expectation.RUNTIME_ERROR) return Expectation.PASS;
ricow1 2015/01/15 09:50:15 why?
Bill Hesse 2015/01/15 10:18:05 Change removed. The _negateOutcomeIfNegativeTest
+ return Expectation.MISSING_COMPILETIME_ERROR ;
ricow1 2015/01/15 09:50:15 remove space before ;
+ }
return _negateOutcomeIfNegativeTest(_rawOutcome, testCase.isNegative);
}
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698