Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 845753002: Call EnsureNSSInit in SSLClientSocket::GetMaxSupportedSSLVersion. (Closed)

Created:
5 years, 11 months ago by davidben
Modified:
5 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call EnsureNSSInit in SSLClientSocket::GetMaxSupportedSSLVersion. EnsureNSSInit needs to query PK11_TokenExists, so NSS needs to be initialized first. BUG=447461 Committed: https://crrev.com/34f538287c2e6d1a9385cb8c9163185560613cda Cr-Commit-Position: refs/heads/master@{#311132}

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : one last compile fix, hopefully #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket_openssl_unittest.cc View 1 2 5 chunks +4 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 25 chunks +27 lines, -33 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
davidben
I had it call EnsureNSSInit rather than EnsureNSSSSLInit because I don't think code needs the ...
5 years, 11 months ago (2015-01-09 15:53:58 UTC) #2
Ryan Sleevi
lgtm
5 years, 11 months ago (2015-01-09 21:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845753002/1
5 years, 11 months ago (2015-01-09 21:10:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/21347)
5 years, 11 months ago (2015-01-10 00:58:55 UTC) #7
davidben
Unfortunately, that one wasn't a flake. Now that SSLConfig's constructor wants to call SSLClientSocket::GetMaxSupportedSSLVersion(), we ...
5 years, 11 months ago (2015-01-12 19:07:22 UTC) #8
Ryan Sleevi
Yeah, that was bad of those tests. LGTM.
5 years, 11 months ago (2015-01-12 20:10:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845753002/40001
5 years, 11 months ago (2015-01-12 20:17:52 UTC) #11
commit-bot: I haz the power
Failed to apply patch for build/sanitizers/tsan_suppressions.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-12 21:14:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845753002/60001
5 years, 11 months ago (2015-01-12 21:35:27 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-12 22:41:50 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 22:42:49 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/34f538287c2e6d1a9385cb8c9163185560613cda
Cr-Commit-Position: refs/heads/master@{#311132}

Powered by Google App Engine
This is Rietveld 408576698