Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 845733002: Fix typo in kBrowserBinaryNames for Epiphany Browser. (Closed)

Created:
5 years, 11 months ago by p.forysiuk
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in kBrowserBinaryNames for Epiphany Browser. Because of the typo Epiphany Browser process would never be matched thus never be included in the memory summary. Since this is my first patch to Chromium project I added myself to AUTHORS file. BUG=NONE TEST=NONE Committed: https://crrev.com/52f6146bdbd80b89805a18995a1dffdd198da8cc Cr-Commit-Position: refs/heads/master@{#312333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
p.forysiuk
I am still awaiting CLA approval
5 years, 11 months ago (2015-01-09 14:37:42 UTC) #3
jochen (gone - plz use gerrit)
sorry, I can't find your email address in the CCLA signed by Samsung so we ...
5 years, 11 months ago (2015-01-12 12:15:21 UTC) #4
p.forysiuk
Sorry. There was a bit of procedural delay it seems. Should be there now (or ...
5 years, 11 months ago (2015-01-19 08:09:30 UTC) #5
jochen (gone - plz use gerrit)
sorry, still nothing in our database
5 years, 11 months ago (2015-01-20 15:48:22 UTC) #6
jochen (gone - plz use gerrit)
now it's in, lgtm
5 years, 11 months ago (2015-01-20 19:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845733002/1
5 years, 11 months ago (2015-01-21 07:51:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 14:01:39 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:04:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52f6146bdbd80b89805a18995a1dffdd198da8cc
Cr-Commit-Position: refs/heads/master@{#312333}

Powered by Google App Engine
This is Rietveld 408576698