Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 845723003: Use the correct content setting for toggling Push Notification permission. (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 11 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct content setting for toggling Push Notification permission. The code is currently toggling the defaults for PUSH_MESSAGING, but it should be using NOTIFICATIONS instead. BUG=90795 Committed: https://crrev.com/95c44bb9cd2e1bdad1eaf99b6a0896708466bb67 Cr-Commit-Position: refs/heads/master@{#310779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/preferences/pref_service_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Miguel Garcia
lgtm
5 years, 11 months ago (2015-01-09 15:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845723003/1
5 years, 11 months ago (2015-01-09 15:58:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 16:42:48 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 16:43:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95c44bb9cd2e1bdad1eaf99b6a0896708466bb67
Cr-Commit-Position: refs/heads/master@{#310779}

Powered by Google App Engine
This is Rietveld 408576698