Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 845713002: Extend grokdump's dd command with a second optional parameter defining number of words to dump. (Closed)

Created:
5 years, 11 months ago by Igor Sheludko
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extend grokdump's dd command with a second optional parameter defining number of words to dump. Committed: https://crrev.com/eecfb9274807575485f05200dd73b413613c8eb0 Cr-Commit-Position: refs/heads/master@{#26007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M tools/grokdump.py View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 11 months ago (2015-01-09 11:21:00 UTC) #2
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-09 11:23:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845713002/1
5 years, 11 months ago (2015-01-09 11:24:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 11:52:25 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 11:52:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eecfb9274807575485f05200dd73b413613c8eb0
Cr-Commit-Position: refs/heads/master@{#26007}

Powered by Google App Engine
This is Rietveld 408576698