Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 845693002: [Password Generation] Require full form match to allow generation (Closed)

Created:
5 years, 11 months ago by Garrett Casto
Modified:
5 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Require full form match to allow generation Previously as long as the origin of the form recieved from Autofill matched the form detected by heuristics (i.e. the page hadn't navigated before parsing the server response), the first form on the page that matched local heuristics was assumed to be the account creation form. BUG=447484 Committed: https://crrev.com/7a4fa8b14caa96d30b4966f5bc9c132f9fcabfd5 Cr-Commit-Position: refs/heads/master@{#310788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -28 lines) Patch
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 13 chunks +64 lines, -17 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Garrett Casto
5 years, 11 months ago (2015-01-09 08:18:36 UTC) #2
vabr (Chromium)
lgtm
5 years, 11 months ago (2015-01-09 08:55:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845693002/1
5 years, 11 months ago (2015-01-09 17:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 17:24:09 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 17:25:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a4fa8b14caa96d30b4966f5bc9c132f9fcabfd5
Cr-Commit-Position: refs/heads/master@{#310788}

Powered by Google App Engine
This is Rietveld 408576698