Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 845683003: Work around failed multicol tests on Mac introduced by enabling HarfBuzz. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Work around failing multicol tests on Mac introduced by enabling HarfBuzz. Two tests fixed: list-item.html and table-cell.html BUG=334269 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/list-item.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/newmulticol/list-item-expected.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/newmulticol/table-cell.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/table-cell-expected.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-09 17:03:37 UTC) #1
andersr
lgtm
5 years, 11 months ago (2015-01-12 09:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845683003/1
5 years, 11 months ago (2015-01-12 10:29:52 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 11:05:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188212

Powered by Google App Engine
This is Rietveld 408576698