Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4129)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/script_request_detector_unittest.cc

Issue 845663004: Initial script request detector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pre-review cleanup Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/script_request_detector_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/script_request_detector_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/script_request_detector_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d8845ea698dee2938199a1db637673057860014d
--- /dev/null
+++ b/chrome/browser/safe_browsing/incident_reporting/script_request_detector_unittest.cc
@@ -0,0 +1,141 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/run_loop.h"
+#include "chrome/browser/safe_browsing/incident_reporting/add_incident_callback.h"
+#include "chrome/browser/safe_browsing/incident_reporting/incident.h"
+#include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
+#include "chrome/browser/safe_browsing/incident_reporting/script_request_detector.h"
+#include "chrome/common/safe_browsing/csd.pb.h"
+#include "content/public/browser/resource_request_info.h"
+#include "content/public/common/resource_type.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "crypto/sha2.h"
+#include "ipc/ipc_message.h"
+#include "net/base/request_priority.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace {
+const char* kMatchingTestUrl = "http://example.com/foo/bar/baz.js";
+const char* kMatchingTestUrlParams =
+ "http://example.com/foo/bar/baz.js#abc?foo=bar";
+const char* kNonMatchingTestUrl = "http://example.com/nonmatching/bar/baz.js";
+}
+
+namespace safe_browsing {
+
+class FakeIncidentReportingService : public IncidentReportingService {
+ public:
+ explicit FakeIncidentReportingService(AddIncidentCallback callback)
+ : IncidentReportingService(NULL, NULL), callback_(callback) {}
+
+ AddIncidentCallback GetAddIncidentCallback(Profile* profile) override {
+ return callback_;
+ }
+
+ private:
+ AddIncidentCallback callback_;
+};
+
+class FakeScriptRequestDetector : public ScriptRequestDetector {
+ public:
+ explicit FakeScriptRequestDetector(
+ IncidentReportingService* incident_reporting_service)
+ : ScriptRequestDetector(incident_reporting_service) {}
+
+ protected:
+ bool AllowNullProfileForTesting() override { return true; }
+};
+
+class ScriptRequestDetectorTest : public testing::Test {
+ public:
+ ScriptRequestDetectorTest()
+ : fake_incident_reporting_service_(
+ base::Bind(&ScriptRequestDetectorTest::OnScriptDetectionEvent,
+ base::Unretained(this))),
+ fake_script_request_detector_(&fake_incident_reporting_service_),
+ script_detection_event_count_(0) {}
+
+ protected:
+ scoped_ptr<net::URLRequest> GetTestURLRequest(
+ const std::string& url,
+ content::ResourceType resource_type) const {
+ scoped_ptr<net::URLRequest> url_request(
+ context_.CreateRequest(GURL(url), net::DEFAULT_PRIORITY, NULL, NULL));
+
+ content::ResourceRequestInfo::AllocateForTesting(
+ url_request.get(), resource_type,
+ NULL, // resource_context
+ 0, // render_process_id
+ 0, // render_view_id
+ MSG_ROUTING_NONE, // render_frame_id
+ true, // is_main_frame
+ false, // parent_is_main_frame
+ true, // allow_download
+ false); // is_async
+
+ return url_request.Pass();
+ }
+
+ protected:
+ FakeIncidentReportingService fake_incident_reporting_service_;
+ FakeScriptRequestDetector fake_script_request_detector_;
+ int script_detection_event_count_;
+ scoped_ptr<ClientIncidentReport_IncidentData> incident_data_;
+
+ private:
+ void OnScriptDetectionEvent(scoped_ptr<Incident> incident) {
+ ++script_detection_event_count_;
+ }
+
+ // UrlRequest requires a message loop. This provides one.
+ content::TestBrowserThreadBundle thread_bundle_;
+ net::TestURLRequestContext context_;
+};
+
+TEST_F(ScriptRequestDetectorTest, NoEventForIgnoredResourceTypes) {
+ scoped_ptr<net::URLRequest> ignored_request(
+ GetTestURLRequest(kNonMatchingTestUrl, content::RESOURCE_TYPE_IMAGE));
+
+ fake_script_request_detector_.OnResourceRequest(ignored_request.get());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(0, script_detection_event_count_);
+}
+
+TEST_F(ScriptRequestDetectorTest, NoEventForNonMatchingScript) {
+ scoped_ptr<net::URLRequest> ignored_request(
+ GetTestURLRequest(kNonMatchingTestUrl, content::RESOURCE_TYPE_SCRIPT));
+
+ fake_script_request_detector_.OnResourceRequest(ignored_request.get());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(0, script_detection_event_count_);
+}
+
+TEST_F(ScriptRequestDetectorTest, EventForBaseMatchingScript) {
+ GURL url(kMatchingTestUrl);
+ scoped_ptr<net::URLRequest> request(
+ GetTestURLRequest(kMatchingTestUrl, content::RESOURCE_TYPE_SCRIPT));
+ fake_script_request_detector_.OnResourceRequest(request.get());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, script_detection_event_count_);
+}
+
+TEST_F(ScriptRequestDetectorTest, EventForMatchingScriptWithParams) {
+ GURL url(kMatchingTestUrlParams);
+ scoped_ptr<net::URLRequest> request(
+ GetTestURLRequest(kMatchingTestUrlParams, content::RESOURCE_TYPE_SCRIPT));
+ fake_script_request_detector_.OnResourceRequest(request.get());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, script_detection_event_count_);
+}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698