chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h - Issue 845663004: Initial script request detector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

Issue 845663004: Initial script request detector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix initializer order. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident.h ('k') | chrome/browser/safe_browsing/incident_reporting/script_request_detector.h » ('j') | chrome/browser/safe_browsing/incident_reporting/script_request_detector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

index 1fac481b235621ffb0d58638d0bbe122f543729f..a80c5bb3adfc66479c259be3c696c14a5dc6f2a6 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h

@@ -81,7 +81,7 @@ class IncidentReportingService : public content::NotificationObserver {

// service on behalf of |profile|. The callback may outlive the service, but

// will no longer have any effect after the service is deleted. The callback

// must not be run after |profile| has been destroyed.

- AddIncidentCallback GetAddIncidentCallback(Profile* profile);

+ virtual AddIncidentCallback GetAddIncidentCallback(Profile* profile);

// Returns a preference validation delegate that adds incidents to the service

// for validation failures in |profile|. The delegate may outlive the service,