Initial script request detector.

chrome/browser/safe_browsing/safe_browsing_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 38 matching lines @@
 
 #if defined(OS_WIN)
 #include "chrome/installer/util/browser_distribution.h"
 #endif
 
 #if defined(FULL_SAFE_BROWSING)
 #include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h"
 #include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer.h"
 #include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
 #include "chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.h"
+#include "chrome/browser/safe_browsing/incident_reporting/script_request_detector.h"
 #include "chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h"
 #endif
 
 using content::BrowserThread;
 
 namespace {
 
 // Filename suffix for the cookie database.
 const base::FilePath::CharType kCookiesFile[] = FILE_PATH_LITERAL(" Cookies");
 
@@ skipping 155 matching lines @@
     csd_service_.reset(safe_browsing::ClientSideDetectionService::Create(
         url_request_context_getter_.get()));
   }
   download_service_.reset(new safe_browsing::DownloadProtectionService(
       this, url_request_context_getter_.get()));
 #endif
 
   if (IsIncidentReportingServiceEnabled()) {
     incident_service_.reset(new safe_browsing::IncidentReportingService(
         this, url_request_context_getter_));
+    script_request_detector_.reset(
+        new safe_browsing::ScriptRequestDetector(
+            incident_service_->GetIncidentReceiver().Pass()));

[grt (UTC plus 2), 2015/02/06 15:24:55]

do you need the .Pass() here? does it compile if you remove it?

[robertshield, 2015/02/06 22:36:48]

Done.

   }
 
   off_domain_inclusion_detector_.reset(
       new safe_browsing::OffDomainInclusionDetector(database_manager_));
 #endif
 
   // Track the safe browsing preference of existing profiles.
   // The SafeBrowsingService will be started if any existing profile has the
   // preference enabled. It will also listen for updates to the preferences.
   ProfileManager* profile_manager = g_browser_process->profile_manager();
@@ skipping 27 matching lines @@
   prefs_registrar_.RemoveAll();
 
   Stop(true);
   // The IO thread is going away, so make sure the ClientSideDetectionService
   // dtor executes now since it may call the dtor of URLFetcher which relies
   // on it.
   csd_service_.reset();
 
 #if defined(FULL_SAFE_BROWSING)
   off_domain_inclusion_detector_.reset();
+  script_request_detector_.reset();
+  // Note that it is important that incident_service_ be destroyed AFTER the

[grt (UTC plus 2), 2015/02/06 15:24:55]

why do you say that? i don't think it's true.

[robertshield, 2015/02/06 22:36:48]

If you recall the earlier revision of the CL, it used to be true. 

It no longer is, so comment removed.

[grt (UTC plus 2), 2015/02/06 23:37:46]

Oh, right. Apologies if that comment sounded snotty or something.

+  // detectors.
   incident_service_.reset();
 #endif
 
   download_service_.reset();
 
   url_request_context_getter_ = NULL;
   BrowserThread::PostNonNestableTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&SafeBrowsingService::DestroyURLRequestContextOnIOThread,
                  this));
@@ skipping 61 matching lines @@
 #if defined(FULL_SAFE_BROWSING)
   if (incident_service_)
     incident_service_->AddDownloadManager(download_manager);
 #endif
 }
 
 void SafeBrowsingService::OnResourceRequest(const net::URLRequest* request) {
 #if defined(FULL_SAFE_BROWSING)
   if (off_domain_inclusion_detector_)
     off_domain_inclusion_detector_->OnResourceRequest(request);
+  if (script_request_detector_)
+    script_request_detector_->OnResourceRequest(request);
 #endif
 }
 
 SafeBrowsingUIManager* SafeBrowsingService::CreateUIManager() {
   return new SafeBrowsingUIManager(this);
 }
 
 SafeBrowsingDatabaseManager* SafeBrowsingService::CreateDatabaseManager() {
 #if defined(FULL_SAFE_BROWSING)
   return new SafeBrowsingDatabaseManager(this);
@@ skipping 205 matching lines @@
   else
     Stop(false);
 
 #if defined(FULL_SAFE_BROWSING)
   if (csd_service_)
     csd_service_->SetEnabledAndRefreshState(enable);
   if (download_service_)
     download_service_->SetEnabled(enable);
 #endif
 }