content/browser/accessibility/browser_accessibility_android.cc - Issue 845663002: On Android, links inside headings should be announced as headings by TalkBack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 845663002: On Android, links inside headings should be announced as headings by TalkBack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating test results for win and mac Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 3480d1fcc916e08486949e2bc56989a605a4b5fe..5e47b42adc40e954bb72f2bcfebfa2cf9081404a 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -194,6 +194,11 @@ bool BrowserAccessibilityAndroid::IsFocused() const {

}

bool BrowserAccessibilityAndroid::IsHeading() const {

+ BrowserAccessibilityAndroid* parent =

+ static_cast<BrowserAccessibilityAndroid*>(GetParent());

+ if(parent && parent->IsHeading())

dmazzoni 2015/01/14 18:03:02 nit: space after the "if" before the "("

+ return true;

return (GetRole() == ui::AX_ROLE_COLUMN_HEADER ||

GetRole() == ui::AX_ROLE_HEADING ||

GetRole() == ui::AX_ROLE_ROW_HEADER);

« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »