Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 845643008: Fix for crash in FPDF_GetNamedDest(). (Closed)

Created:
5 years, 11 months ago by Deepak
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez, Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for crash in FPDF_GetNamedDest(). pDestObj is getting accessed with NULL value. Check added so that access does not happen with NULL pointer. BUG=450133

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing len to buflen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M fpdfsdk/src/fpdfview.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Deepak
PTAL.
5 years, 11 months ago (2015-01-20 07:20:12 UTC) #2
Tom Sepez
LGTM. Would you happen to have a test case that hits this condition?
5 years, 11 months ago (2015-01-20 17:51:12 UTC) #3
Tom Sepez
https://codereview.chromium.org/845643008/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/845643008/diff/1/fpdfsdk/src/fpdfview.cpp#newcode864 fpdfsdk/src/fpdfview.cpp:864: len = -1; nit: Bo, this looks wrong. Did ...
5 years, 11 months ago (2015-01-20 18:42:28 UTC) #5
Bo Xu
https://codereview.chromium.org/845643008/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/845643008/diff/1/fpdfsdk/src/fpdfview.cpp#newcode864 fpdfsdk/src/fpdfview.cpp:864: len = -1; On 2015/01/20 18:42:28, Tom Sepez wrote: ...
5 years, 11 months ago (2015-01-20 18:45:56 UTC) #6
Tom Sepez
@Deepak, do you need one of us to land this for you?
5 years, 11 months ago (2015-01-20 19:07:32 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-21 02:55:47 UTC) #12
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-21 03:00:52 UTC) #15
Deepak
On 2015/01/21 03:00:52, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
5 years, 11 months ago (2015-01-21 03:04:21 UTC) #16
Tom Sepez
5 years, 11 months ago (2015-01-21 21:16:34 UTC) #17
> @Tom
> Can someone please land this patch for me.
> I am not able to land this, because of above error.
> Thanks

I'll roll this into https://codereview.chromium.org/837723009/.  Thanks for your
patch.

Powered by Google App Engine
This is Rietveld 408576698