Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 845643005: Script streaming: don't produce (empty) cached data when debugger forces eagerness. (Closed)

Created:
5 years, 11 months ago by marja
Modified:
5 years, 11 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Script streaming: don't produce (empty) cached data when debugger forces eagerness. See CompileTopLevel for similar logic which suppresses producing parser cache when the debugger is active. BUG=441130 LOG=n Committed: https://crrev.com/af8a0c0d823784320b85bb802046eff20dcdd424 Cr-Commit-Position: refs/heads/master@{#26138}

Patch Set 1 #

Patch Set 2 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M src/background-parsing-task.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
marja
vogelheim, ptal at this easy cached data related fix.
5 years, 11 months ago (2015-01-19 11:50:45 UTC) #2
vogelheim
lgtm
5 years, 11 months ago (2015-01-19 12:36:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845643005/1
5 years, 11 months ago (2015-01-19 12:43:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/2232)
5 years, 11 months ago (2015-01-19 13:44:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845643005/20001
5 years, 11 months ago (2015-01-19 14:03:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-19 14:29:07 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 14:29:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af8a0c0d823784320b85bb802046eff20dcdd424
Cr-Commit-Position: refs/heads/master@{#26138}

Powered by Google App Engine
This is Rietveld 408576698