sky/viewer/services/inspector_impl.cc - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/services/inspector_impl.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/services/inspector_impl.cc

diff --git a/sky/viewer/services/inspector_impl.cc b/sky/viewer/services/inspector_impl.cc

index 367c71544b551b0cce35fe297ef1dbb7eed701e2..d85c3e37df1b6fb36abeb0fad52497c0c99d8c0b 100644

--- a/sky/viewer/services/inspector_impl.cc

+++ b/sky/viewer/services/inspector_impl.cc

@@ -29,7 +29,8 @@ void InspectorServiceImpl::Inject() {

mojo::ServiceProviderPtr inspector_service_provider;

view_->shell()->ConnectToApplication("mojo:sky_inspector_server",

- GetProxy(&inspector_service_provider));

+ GetProxy(&inspector_service_provider),

+ nullptr);

InspectorServerPtr inspector;

mojo::ConnectToService(inspector_service_provider.get(), &inspector);

inspector->Listen(9898, base::Bind(&Ignored));

« no previous file with comments | « sky/viewer/internals.cc ('k') | no next file » | no next file with comments »