sky/viewer/internals.h - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/internals.h

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/internals.h

diff --git a/sky/viewer/internals.h b/sky/viewer/internals.h

index 58a7781af997a5af714bb7df629b2fffb5685ba6..e546b922dd646966ca0f99572f4aba3519c07283 100644

--- a/sky/viewer/internals.h

+++ b/sky/viewer/internals.h

@@ -31,8 +31,9 @@ class Internals : public gin::Wrappable<Internals>,

// mojo::Shell method:

void ConnectToApplication(

- const mojo::String& application_url,

- mojo::InterfaceRequest<mojo::ServiceProvider> provider) override;

+ const mojo::String& application_url,

+ mojo::InterfaceRequest<mojo::ServiceProvider> services,

+ mojo::ServiceProviderPtr exposed_services) override;

mojo::Handle PassShellProxyHandle();

std::string RenderTreeAsText();

« no previous file with comments | « sky/viewer/document_view.cc ('k') | sky/viewer/internals.cc » ('j') | no next file with comments »