sky/viewer/document_view.h - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/document_view.h

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/document_view.h

diff --git a/sky/viewer/document_view.h b/sky/viewer/document_view.h

index 98d8513ca395601467e38aab668a47bbe81c5519..1c80db9f69504a159099257ed9a1bd05ef209fef 100644

--- a/sky/viewer/document_view.h

+++ b/sky/viewer/document_view.h

@@ -47,7 +47,8 @@ class DocumentView : public blink::ServiceProvider,

public mojo::ViewManagerDelegate,

public mojo::ViewObserver {

public:

- DocumentView(mojo::ServiceProviderPtr provider,

+ DocumentView(mojo::InterfaceRequest<mojo::ServiceProvider> services,

+ mojo::ServiceProviderPtr exported_services,

mojo::URLResponsePtr response,

mojo::Shell* shell);

virtual ~DocumentView();

« no previous file with comments | « sky/viewer/content_handler_impl.cc ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »