Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: mojo/services/public/js/application.js

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/interfaces/application/shell.mojom ('k') | services/js/echo_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/js/application.js
diff --git a/mojo/services/public/js/application.js b/mojo/services/public/js/application.js
index 77ec17fd60e39ab90c1c67b8e87f67cc4abebecf..452d561fef5f48164c47b3a90e634cc2bc610d0e 100644
--- a/mojo/services/public/js/application.js
+++ b/mojo/services/public/js/application.js
@@ -15,6 +15,7 @@ define("mojo/services/public/js/application", [
constructor(shellHandle, url) {
this.url = url;
this.serviceProviders = [];
+ this.exposedServiceProviders = [];
this.shellHandle_ = shellHandle;
this.shell = new Shell(shellHandle, {
initialize: this.initialize.bind(this),
@@ -25,13 +26,18 @@ define("mojo/services/public/js/application", [
initialize(args) {
}
- doAcceptConnection(url, serviceProviderProxy) {
- var serviceProvider = new ServiceProvider(serviceProviderProxy);
+ doAcceptConnection(url, serviceProviderProxy, exposedServiceProviderProxy) {
+ var serviceProvider = new ServiceProvider(serviceProviderProxy);
this.serviceProviders.push(serviceProvider);
- this.acceptConnection(url, serviceProvider);
+
+ var exposedServiceProvider =
+ new ServiceProvider(exposedServiceProviderProxy);
+ this.exposedServiceProviders.push(exposedServiceProvider)
+
+ this.acceptConnection(url, serviceProvider, exposedServiceProvider);
}
- acceptConnection(url, serviceProvider) {
+ acceptConnection(url, serviceProvider, exposedServiceProvider) {
}
quit() {
« no previous file with comments | « mojo/public/interfaces/application/shell.mojom ('k') | services/js/echo_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698