Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: mojo/application_manager/application_manager.h

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/ganesh_app/texture_uploader.cc ('k') | mojo/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application_manager/application_manager.h
diff --git a/mojo/application_manager/application_manager.h b/mojo/application_manager/application_manager.h
index f98f17a4a31c534dbbe4877f31a5e49f7fb9a96e..75a3d06b2f4fa0e8146b1b264c54cebeae608c94 100644
--- a/mojo/application_manager/application_manager.h
+++ b/mojo/application_manager/application_manager.h
@@ -48,13 +48,14 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
DISALLOW_COPY_AND_ASSIGN(TestAPI);
};
- ApplicationManager(Delegate* delegate);
+ explicit ApplicationManager(Delegate* delegate);
~ApplicationManager();
// Loads a service if necessary and establishes a new client connection.
void ConnectToApplication(const GURL& application_url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider);
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services);
template <typename Interface>
inline void ConnectToService(const GURL& application_url,
@@ -110,13 +111,15 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
void ConnectToApplicationImpl(const GURL& requested_url,
const GURL& resolved_url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider,
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services,
ApplicationLoader* loader);
void ConnectToClient(ShellImpl* shell_impl,
const GURL& url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider);
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services);
void LoadWithContentHandler(const GURL& content_handler_url,
ScopedMessagePipeHandle shell_handle,
« no previous file with comments | « examples/ganesh_app/texture_uploader.cc ('k') | mojo/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698