services/js/echo_apptest.cc - Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/js/echo_apptest.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: services & exposed_services Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/js/echo_apptest.cc

diff --git a/services/js/echo_apptest.cc b/services/js/echo_apptest.cc

index 0a2bf3588049b38f330c951ce18c0faaf8c057c3..cc247f475195952f45aca0b96ff1d51957d682df 100644

--- a/services/js/echo_apptest.cc

+++ b/services/js/echo_apptest.cc

@@ -40,7 +40,7 @@ class JSServiceProviderEchoTest : public test::JSApplicationTestBase {

ApplicationTestBase::SetUp();

const std::string& url = JSAppURL("echo.js");

application_impl()->shell()->ConnectToApplication(

- url, GetProxy(&echo_service_provider_));

+ url, GetProxy(&echo_service_provider_), mojo::ServiceProviderPtr());

}

mojo::ServiceProviderPtr echo_service_provider_;