Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: mojo/aura/surface_binding.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: services & exposed_services Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/aura/surface_binding.cc
diff --git a/mojo/aura/surface_binding.cc b/mojo/aura/surface_binding.cc
index 618db38246f7db8503b8d377ef0111d73dedbb90..38ecea01f57993d1f62d30ae490705d1c0d36a1d 100644
--- a/mojo/aura/surface_binding.cc
+++ b/mojo/aura/surface_binding.cc
@@ -207,7 +207,8 @@ void SurfaceBinding::PerViewManagerState::Init() {
ServiceProviderPtr surfaces_service_provider;
shell_->ConnectToApplication("mojo:surfaces_service",
- GetProxy(&surfaces_service_provider));
+ GetProxy(&surfaces_service_provider),
+ ServiceProviderPtr());
ConnectToService(surfaces_service_provider.get(), &surfaces_service_);
// base::Unretained is ok here as we block until the call is received.
surfaces_service_->CreateSurfaceConnection(
@@ -224,7 +225,8 @@ void SurfaceBinding::PerViewManagerState::Init() {
ServiceProviderPtr gpu_service_provider;
// TODO(jamesr): Should be mojo:gpu_service
shell_->ConnectToApplication("mojo:native_viewport_service",
- GetProxy(&gpu_service_provider));
+ GetProxy(&gpu_service_provider),
+ ServiceProviderPtr());
ConnectToService(gpu_service_provider.get(), &gpu_);
}

Powered by Google App Engine
This is Rietveld 408576698