Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: examples/bitmap_uploader/bitmap_uploader.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: services & exposed_services Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/bitmap_uploader/bitmap_uploader.cc
diff --git a/examples/bitmap_uploader/bitmap_uploader.cc b/examples/bitmap_uploader/bitmap_uploader.cc
index 07becf6c7a03b2d8c6cf5edeac94fd493a176967..de634329f2c63c1daf131e0af51f844d57a765ab 100644
--- a/examples/bitmap_uploader/bitmap_uploader.cc
+++ b/examples/bitmap_uploader/bitmap_uploader.cc
@@ -45,11 +45,13 @@ BitmapUploader::BitmapUploader(View* view)
void BitmapUploader::Init(Shell* shell) {
ServiceProviderPtr surfaces_service_provider;
shell->ConnectToApplication("mojo:surfaces_service",
- GetProxy(&surfaces_service_provider));
+ GetProxy(&surfaces_service_provider),
+ ServiceProviderPtr());
darin (slow to review) 2015/01/13 07:54:51 note for a future CL: we could make nullptr work i
ConnectToService(surfaces_service_provider.get(), &surfaces_service_);
ServiceProviderPtr gpu_service_provider;
shell->ConnectToApplication("mojo:native_viewport_service",
- GetProxy(&gpu_service_provider));
+ GetProxy(&gpu_service_provider),
+ ServiceProviderPtr());
ConnectToService(gpu_service_provider.get(), &gpu_service_);
surfaces_service_->CreateSurfaceConnection(base::Bind(

Powered by Google App Engine
This is Rietveld 408576698