Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: sky/viewer/content_handler_impl.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/viewer/content_handler_impl.cc
diff --git a/sky/viewer/content_handler_impl.cc b/sky/viewer/content_handler_impl.cc
index e4ceaec945b4bbcc16bae8aafb6d8e067e542337..3237a8a3f92a9c30ef30a1ea2c2d3de025ce79a3 100644
--- a/sky/viewer/content_handler_impl.cc
+++ b/sky/viewer/content_handler_impl.cc
@@ -21,17 +21,19 @@ class SkyApplication : public mojo::Application {
shell_.set_client(this);
mojo::ServiceProviderPtr service_provider;
shell_->ConnectToApplication("mojo:network_service",
- mojo::GetProxy(&service_provider));
+ mojo::GetProxy(&service_provider),
+ mojo::ServiceProviderPtr());
mojo::ConnectToService(service_provider.get(), &network_service_);
}
void Initialize(mojo::Array<mojo::String> args) override {}
void AcceptConnection(const mojo::String& requestor_url,
- mojo::ServiceProviderPtr provider) override {
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::ServiceProviderPtr exported_services) override {
if (initial_response_) {
- OnResponseReceived(mojo::URLLoaderPtr(), provider.Pass(),
- initial_response_.Pass());
+ OnResponseReceived(mojo::URLLoaderPtr(), services.Pass(),
+ exported_services.Pass(), initial_response_.Pass());
} else {
mojo::URLLoaderPtr loader;
network_service_->CreateURLLoader(mojo::GetProxy(&loader));
@@ -47,15 +49,19 @@ class SkyApplication : public mojo::Application {
request.Pass(),
base::Bind(&SkyApplication::OnResponseReceived,
base::Unretained(this), base::Passed(&loader),
- base::Passed(&provider)));
+ base::Passed(&services),
+ base::Passed(&exported_services)));
}
}
private:
- void OnResponseReceived(mojo::URLLoaderPtr loader,
- mojo::ServiceProviderPtr provider,
- mojo::URLResponsePtr response) {
- new DocumentView(provider.Pass(), response.Pass(), shell_.get());
+ void OnResponseReceived(
+ mojo::URLLoaderPtr loader,
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::ServiceProviderPtr exported_services,
+ mojo::URLResponsePtr response) {
+ new DocumentView(services.Pass(), exported_services.Pass(), response.Pass(),
+ shell_.get());
}
mojo::String url_;

Powered by Google App Engine
This is Rietveld 408576698