Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: mojo/application_manager/application_manager.h

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application_manager/application_manager.h
diff --git a/mojo/application_manager/application_manager.h b/mojo/application_manager/application_manager.h
index 0a8906adc94abaa2ac5374661048f3ae585413cc..c1b4df0038de2e27ae3c559f5ec67a694e6a1a27 100644
--- a/mojo/application_manager/application_manager.h
+++ b/mojo/application_manager/application_manager.h
@@ -47,13 +47,14 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
DISALLOW_COPY_AND_ASSIGN(TestAPI);
};
- ApplicationManager(Delegate* delegate);
+ explicit ApplicationManager(Delegate* delegate);
~ApplicationManager();
// Loads a service if necessary and establishes a new client connection.
void ConnectToApplication(const GURL& application_url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider);
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exported_services);
template <typename Interface>
inline void ConnectToService(const GURL& application_url,
@@ -107,13 +108,15 @@ class MOJO_APPLICATION_MANAGER_EXPORT ApplicationManager {
void ConnectToApplicationImpl(const GURL& requested_url,
const GURL& resolved_url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider,
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exported_services,
ApplicationLoader* loader);
void ConnectToClient(ShellImpl* shell_impl,
const GURL& url,
const GURL& requestor_url,
- ServiceProviderPtr service_provider);
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exported_services);
void LoadWithContentHandler(const GURL& content_handler_url,
ScopedMessagePipeHandle shell_handle,

Powered by Google App Engine
This is Rietveld 408576698