Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: mojo/application_manager/shell_impl.cc

Issue 845593003: Pass ServiceProvider and ServiceProvider& params in Connect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: use nullptr instead of ServiceProviderPtr(), fix ShellImpl Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/application_manager/shell_impl.h ('k') | mojo/gpu/gl_context.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/application_manager/shell_impl.h" 5 #include "mojo/application_manager/shell_impl.h"
6 6
7 #include "mojo/application_manager/application_manager.h" 7 #include "mojo/application_manager/application_manager.h"
8 #include "mojo/common/common_type_converters.h" 8 #include "mojo/common/common_type_converters.h"
9 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h" 9 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h"
10 10
(...skipping 12 matching lines...) Expand all
23 const GURL& requested_url, 23 const GURL& requested_url,
24 const GURL& url) 24 const GURL& url)
25 : ShellImpl(manager, requested_url, url) { 25 : ShellImpl(manager, requested_url, url) {
26 binding_.Bind(ptr); 26 binding_.Bind(ptr);
27 } 27 }
28 28
29 ShellImpl::~ShellImpl() { 29 ShellImpl::~ShellImpl() {
30 } 30 }
31 31
32 void ShellImpl::ConnectToClient(const GURL& requestor_url, 32 void ShellImpl::ConnectToClient(const GURL& requestor_url,
33 ServiceProviderPtr service_provider) { 33 InterfaceRequest<ServiceProvider> services,
34 client()->AcceptConnection(String::From(requestor_url), 34 ServiceProviderPtr exposed_services) {
35 service_provider.Pass()); 35 client()->AcceptConnection(String::From(requestor_url), services.Pass(),
36 exposed_services.Pass());
36 } 37 }
37 38
38 ShellImpl::ShellImpl(ApplicationManager* manager, 39 ShellImpl::ShellImpl(ApplicationManager* manager,
39 const GURL& requested_url, 40 const GURL& requested_url,
40 const GURL& url) 41 const GURL& url)
41 : manager_(manager), 42 : manager_(manager),
42 requested_url_(requested_url), 43 requested_url_(requested_url),
43 url_(url), 44 url_(url),
44 binding_(this) { 45 binding_(this) {
45 binding_.set_error_handler(this); 46 binding_.set_error_handler(this);
46 } 47 }
47 48
48 // Shell implementation: 49 // Shell implementation:
49 void ShellImpl::ConnectToApplication( 50 void ShellImpl::ConnectToApplication(const String& app_url,
50 const String& app_url, 51 InterfaceRequest<ServiceProvider> services,
51 InterfaceRequest<ServiceProvider> in_service_provider) { 52 ServiceProviderPtr exposed_services) {
52 ServiceProviderPtr out_service_provider;
53 out_service_provider.Bind(in_service_provider.PassMessagePipe());
54 GURL app_gurl(app_url); 53 GURL app_gurl(app_url);
55 if (!app_gurl.is_valid()) { 54 if (!app_gurl.is_valid()) {
56 LOG(ERROR) << "Error: invalid URL: " << app_url; 55 LOG(ERROR) << "Error: invalid URL: " << app_url;
57 return; 56 return;
58 } 57 }
59 manager_->ConnectToApplication(app_gurl, url_, out_service_provider.Pass()); 58 manager_->ConnectToApplication(app_gurl, url_, services.Pass(),
59 exposed_services.Pass());
60 } 60 }
61 61
62 void ShellImpl::OnConnectionError() { 62 void ShellImpl::OnConnectionError() {
63 manager_->OnShellImplError(this); 63 manager_->OnShellImplError(this);
64 } 64 }
65 65
66 } // namespace mojo 66 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/application_manager/shell_impl.h ('k') | mojo/gpu/gl_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698