Pass ServiceProvider and ServiceProvider& params in Connect

mojo/public/interfaces/application/application.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module mojo;
 
 import "mojo/public/interfaces/application/service_provider.mojom";
 
 // Applications vend Services through the ServiceProvider interface. Services
 // implement Interfaces.
 interface Application {
   // Initialize is guaranteed to be called before any AcceptConnection calls.
   Initialize(array<string>? args);
 
-  AcceptConnection(string? requestor_url, ServiceProvider? provider);
+  // Called in response to a call to mojo.Shell.ConnectToApplication().
+  AcceptConnection(string? requestor_url,

[Aaron Boodman, 2015/01/09 17:53:36]

We should really remove the question mark. requestor_url is not optional. I can
do it in a separate change though.

+                   ServiceProvider&? services,

[darin (slow to review), 2015/01/09 17:31:16]

I'm a little confused by the use of & here. Usually that is a way to get
something, and I would expect the thing the caller gets here to be the exported
services. It seems like the signature should be:

  AccceptConnection(string? requestor_url,
                    ServiceProvider? requestor_services,
                    ServiceProvider&? exported_services);

[Aaron Boodman, 2015/01/09 17:53:35]

These names are always confusing because they can be interpreted both ways:

'exported_services' can mean either services exported from the app receiving
this call, or services exported from the app making the call.

Perhaps we should say connector and connectee, or requestor and requestee, or
client and provider...

+                   ServiceProvider? exported_services);
 };