Rename SyncStatusHelper to AndroidSyncSettings.

Rename SyncStatusHelper to AndroidSyncSettings.

Also renamed a bunch of the public methods for clarity.

The old SyncStatusHelper class will be removed once downstream is
updated.

Committed: https://crrev.com/921392d21263c05b374d94ae3da3120094cd6a65
Cr-Commit-Position: refs/heads/master@{#312915}

[maxbogue, 2015-01-14 20:54:40]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[maxbogue, 2015-01-14 20:54:41]

For once the SyncController change is in :)

[nyquist, 2015-01-16 17:52:25]

lgtm \o/

https://codereview.chromium.org/845543005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
(right):

https://codereview.chromium.org/845543005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java:48:
public SyncNotificationController(Context context,
Nit: Add a comment that this is deprecated?

https://codereview.chromium.org/845543005/diff/1/sync/android/java/src/org/ch...
File sync/android/java/src/org/chromium/sync/SyncConstants.java (right):

https://codereview.chromium.org/845543005/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/SyncConstants.java:8: public class
SyncConstants {
Nit: Add final

[maxbogue, 2015-01-16 23:38:27]

https://codereview.chromium.org/845543005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
(right):

https://codereview.chromium.org/845543005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java:48:
public SyncNotificationController(Context context,
On 2015/01/16 17:52:25, nyquist wrote:
> Nit: Add a comment that this is deprecated?

I'm going to actually mark it @Deprecated as well.

https://codereview.chromium.org/845543005/diff/1/sync/android/java/src/org/ch...
File sync/android/java/src/org/chromium/sync/SyncConstants.java (right):

https://codereview.chromium.org/845543005/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/SyncConstants.java:8: public class
SyncConstants {
On 2015/01/16 17:52:25, nyquist wrote:
> Nit: Add final

Done.

[maxbogue, 2015-01-23 06:39:18]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-01-23 06:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845543005/60001

[commit-bot: I haz the power, 2015-01-23 07:01:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 07:01:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2015-01-23 07:19:14]

Had to edit some DEPS files; PTAL!

[nyquist, 2015-01-23 18:50:30]

thanks for the request for re-review.
lgtm

[maxbogue, 2015-01-23 19:19:43]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-01-23 19:20:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845543005/80001

[commit-bot: I haz the power, 2015-01-23 20:16:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-23 20:17:19]

Patchset 5 (id:??) landed as
https://crrev.com/921392d21263c05b374d94ae3da3120094cd6a65
Cr-Commit-Position: refs/heads/master@{#312915}