Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 845543004: Run task queue manager work in batches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Header cleanup. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/renderer_scheduler_impl.h" 5 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/debug/trace_event_argument.h" 9 #include "base/debug/trace_event_argument.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 25 matching lines...) Expand all
36 end_idle_period_closure_ = base::Bind(&RendererSchedulerImpl::EndIdlePeriod, 36 end_idle_period_closure_ = base::Bind(&RendererSchedulerImpl::EndIdlePeriod,
37 weak_renderer_scheduler_ptr_); 37 weak_renderer_scheduler_ptr_);
38 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner( 38 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner(
39 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE), 39 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE),
40 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback, 40 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback,
41 weak_renderer_scheduler_ptr_))); 41 weak_renderer_scheduler_ptr_)));
42 renderer_task_queue_selector_->SetQueuePriority( 42 renderer_task_queue_selector_->SetQueuePriority(
43 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY); 43 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY);
44 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 44 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
45 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false); 45 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false);
46 // See crbug.com/444764 for how this work batch size was derived.
47 task_queue_manager_->SetWorkBatchSize(4);
46 48
47 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) { 49 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) {
48 task_queue_manager_->SetQueueName( 50 task_queue_manager_->SetQueueName(
49 i, TaskQueueIdToString(static_cast<QueueId>(i))); 51 i, TaskQueueIdToString(static_cast<QueueId>(i)));
50 } 52 }
51 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 53 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
52 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler", 54 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler",
53 this); 55 this);
54 } 56 }
55 57
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE); 234 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE);
233 } 235 }
234 236
235 void RendererSchedulerImpl::EndIdlePeriod() { 237 void RendererSchedulerImpl::EndIdlePeriod() {
236 TRACE_EVENT_ASYNC_END0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), 238 TRACE_EVENT_ASYNC_END0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
237 "RendererSchedulerIdlePeriod", this); 239 "RendererSchedulerIdlePeriod", this);
238 main_thread_checker_.CalledOnValidThread(); 240 main_thread_checker_.CalledOnValidThread();
239 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 241 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
240 } 242 }
241 243
244 void RendererSchedulerImpl::SetTimeSourceForTesting(
245 scoped_refptr<cc::TestNowSource> time_source) {
246 main_thread_checker_.CalledOnValidThread();
247 time_source_ = time_source;
248 task_queue_manager_->SetTimeSourceForTesting(time_source);
249 }
250
242 base::TimeTicks RendererSchedulerImpl::Now() const { 251 base::TimeTicks RendererSchedulerImpl::Now() const {
243 return gfx::FrameTime::Now(); 252 return UNLIKELY(time_source_) ? time_source_->Now() : base::TimeTicks::Now();
244 } 253 }
245 254
246 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag( 255 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag(
247 base::Lock* write_lock_) 256 base::Lock* write_lock_)
248 : flag_(false), write_lock_(write_lock_) { 257 : flag_(false), write_lock_(write_lock_) {
249 } 258 }
250 259
251 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() { 260 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() {
252 } 261 }
253 262
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 state->SetDouble("last_input_time", 315 state->SetDouble("last_input_time",
307 (last_input_time_ - base::TimeTicks()).InMillisecondsF()); 316 (last_input_time_ - base::TimeTicks()).InMillisecondsF());
308 state->SetDouble( 317 state->SetDouble(
309 "estimated_next_frame_begin", 318 "estimated_next_frame_begin",
310 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF()); 319 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
311 320
312 return state; 321 return state;
313 } 322 }
314 323
315 } // namespace content 324 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698