Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 845543004: Run task queue manager work in batches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK tweak. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/renderer_scheduler_impl.h" 5 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop_proxy.h" 8 #include "base/message_loop/message_loop_proxy.h"
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "base/trace_event/trace_event_argument.h" 10 #include "base/trace_event/trace_event_argument.h"
(...skipping 27 matching lines...) Expand all
38 end_idle_period_closure_.Reset(base::Bind( 38 end_idle_period_closure_.Reset(base::Bind(
39 &RendererSchedulerImpl::EndIdlePeriod, weak_renderer_scheduler_ptr_)); 39 &RendererSchedulerImpl::EndIdlePeriod, weak_renderer_scheduler_ptr_));
40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner( 40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner(
41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE), 41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE),
42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback, 42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback,
43 weak_renderer_scheduler_ptr_))); 43 weak_renderer_scheduler_ptr_)));
44 renderer_task_queue_selector_->SetQueuePriority( 44 renderer_task_queue_selector_->SetQueuePriority(
45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY); 45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY);
46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false); 47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false);
48 // TODO(skyostil): Increase this to 4 (crbug.com/444764).
49 task_queue_manager_->SetWorkBatchSize(1);
48 50
49 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) { 51 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) {
50 task_queue_manager_->SetQueueName( 52 task_queue_manager_->SetQueueName(
51 i, TaskQueueIdToString(static_cast<QueueId>(i))); 53 i, TaskQueueIdToString(static_cast<QueueId>(i)));
52 } 54 }
53 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 55 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
54 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler", 56 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler",
55 this); 57 this);
56 } 58 }
57 59
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 } 250 }
249 251
250 void RendererSchedulerImpl::EndIdlePeriod() { 252 void RendererSchedulerImpl::EndIdlePeriod() {
251 TRACE_EVENT_ASYNC_END0("renderer.scheduler", 253 TRACE_EVENT_ASYNC_END0("renderer.scheduler",
252 "RendererSchedulerIdlePeriod", this); 254 "RendererSchedulerIdlePeriod", this);
253 main_thread_checker_.CalledOnValidThread(); 255 main_thread_checker_.CalledOnValidThread();
254 end_idle_period_closure_.Cancel(); 256 end_idle_period_closure_.Cancel();
255 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 257 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
256 } 258 }
257 259
260 void RendererSchedulerImpl::SetTimeSourceForTesting(
261 scoped_refptr<cc::TestNowSource> time_source) {
262 main_thread_checker_.CalledOnValidThread();
263 time_source_ = time_source;
264 task_queue_manager_->SetTimeSourceForTesting(time_source);
265 }
266
258 base::TimeTicks RendererSchedulerImpl::Now() const { 267 base::TimeTicks RendererSchedulerImpl::Now() const {
259 return gfx::FrameTime::Now(); 268 return UNLIKELY(time_source_) ? time_source_->Now() : base::TimeTicks::Now();
260 } 269 }
261 270
262 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag( 271 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag(
263 base::Lock* write_lock_) 272 base::Lock* write_lock_)
264 : flag_(false), write_lock_(write_lock_) { 273 : flag_(false), write_lock_(write_lock_) {
265 } 274 }
266 275
267 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() { 276 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() {
268 } 277 }
269 278
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 state->SetDouble("last_input_time", 333 state->SetDouble("last_input_time",
325 (last_input_time_ - base::TimeTicks()).InMillisecondsF()); 334 (last_input_time_ - base::TimeTicks()).InMillisecondsF());
326 state->SetDouble( 335 state->SetDouble(
327 "estimated_next_frame_begin", 336 "estimated_next_frame_begin",
328 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF()); 337 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
329 338
330 return state; 339 return state;
331 } 340 }
332 341
333 } // namespace content 342 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/scheduler/renderer_scheduler_impl.h ('k') | content/renderer/scheduler/renderer_scheduler_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698