Issue 845523004: console.error when using unknown attributes in templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 845523004: console.error when using unknown attributes in templates. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

console.error when using unknown attributes in templates. Log an error whenever an element has an unknown attribute in a template. This means you can't use generic attributes like Polymer, but we probably want to discourage that anyway since attribute selectors should be avoided for most things. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8ba5a127a552920c489e7faacd72838aa6ee2cae

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -9 lines)			Patch
M	sky/examples/city-list/city-list.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/widgets/index.sky	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sky/framework/sky-element/sky-binder.sky	View	4 chunks	+58 lines, -0 lines	0 comments	Download
M	sky/framework/sky-element/sky-element.sky	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	sky/tests/framework/templates.sky	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/tests/resources/test-element.sky	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-09 00:52:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8ba5a127a552920c489e7faacd72838aa6ee2cae (presubmit successful).