Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: ui/events/platform/x11/x11_hotplug_event_handler.cc

Issue 845413002: touch: Change how touch-screen capability is processed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/evdev/event_factory_evdev.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/platform/x11/x11_hotplug_event_handler.cc
diff --git a/ui/events/platform/x11/x11_hotplug_event_handler.cc b/ui/events/platform/x11/x11_hotplug_event_handler.cc
index 1fbdde3e3b61a6a9b9fdaece306a8c1f22099027..549a0826a659842c58977a6c9f5980fe45f9c8db 100644
--- a/ui/events/platform/x11/x11_hotplug_event_handler.cc
+++ b/ui/events/platform/x11/x11_hotplug_event_handler.cc
@@ -82,10 +82,13 @@ struct ValuatorClassInfo {
// Stores a copy of the XITouchClassInfo values so X11 device processing can
// happen on a worker thread. This is needed since X11 structs are not copyable.
struct TouchClassInfo {
- TouchClassInfo(const XITouchClassInfo& info)
- : mode(info.mode) {}
+ TouchClassInfo() : mode(0), num_touches(0) {}
+
+ explicit TouchClassInfo(const XITouchClassInfo& info)
+ : mode(info.mode), num_touches(info.num_touches) {}
int mode;
+ int num_touches;
};
struct DeviceInfo {
@@ -102,8 +105,11 @@ struct DeviceInfo {
*reinterpret_cast<XIValuatorClassInfo*>(device.classes[i])));
break;
case XITouchClass:
- touch_class_infos.push_back(TouchClassInfo(
- *reinterpret_cast<XITouchClassInfo*>(device.classes[i])));
+ // A device can have at most one XITouchClassInfo. Ref:
+ // http://manpages.ubuntu.com/manpages/saucy/man3/XIQueryDevice.3.html
+ DCHECK(!touch_class_info.mode);
+ touch_class_info = TouchClassInfo(
+ *reinterpret_cast<XITouchClassInfo*>(device.classes[i]));
break;
default:
break;
@@ -128,7 +134,7 @@ struct DeviceInfo {
std::vector<ValuatorClassInfo> valuator_class_infos;
- std::vector<TouchClassInfo> touch_class_infos;
+ TouchClassInfo touch_class_info;
};
// X11 display cache used on worker threads. This is filled on the UI thread and
@@ -270,9 +276,8 @@ void HandleTouchscreenDevicesInWorker(
}
}
- for (const TouchClassInfo& info : device_info.touch_class_infos) {
- is_direct_touch = info.mode == XIDirectTouch;
- }
+ if (device_info.touch_class_info.mode)
+ is_direct_touch = device_info.touch_class_info.mode == XIDirectTouch;
// Touchscreens should have absolute X and Y axes, and be direct touch
// devices.
@@ -280,11 +285,10 @@ void HandleTouchscreenDevicesInWorker(
InputDeviceType type = GetInputDeviceTypeFromPath(device_info.path);
// |max_x| and |max_y| are inclusive values, so we need to add 1 to get
// the size.
- devices.push_back(TouchscreenDevice(
- device_info.id,
- type,
- device_info.name,
- gfx::Size(max_x + 1, max_y + 1)));
+ devices.push_back(
+ TouchscreenDevice(device_info.id, type, device_info.name,
+ gfx::Size(max_x + 1, max_y + 1),
+ device_info.touch_class_info.num_touches));
}
}
« no previous file with comments | « ui/events/ozone/evdev/event_factory_evdev.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698