sky/engine/bindings/core/v8/V8Initializer.cpp - Issue 845403009: Turn on harmony arrays and regexp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8Initializer.cpp

Issue 845403009: Turn on harmony arrays and regexp. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8Initializer.cpp

diff --git a/sky/engine/bindings/core/v8/V8Initializer.cpp b/sky/engine/bindings/core/v8/V8Initializer.cpp

index 0818fc758e4079897000a7d242c66b85ce1ca82e..6551d81deccf8d61e0f933d03cf41992a77bb518 100644

--- a/sky/engine/bindings/core/v8/V8Initializer.cpp

+++ b/sky/engine/bindings/core/v8/V8Initializer.cpp

@@ -200,7 +200,7 @@ void V8Initializer::initializeMainThreadIfNeeded()

return;

initialized = true;

- static const char v8Flags[] = "--harmony-classes";

+ static const char v8Flags[] = "--harmony-classes --harmony-arrays --harmony-array-includes --harmony-regexps";

v8::V8::SetFlagsFromString(v8Flags, sizeof(v8Flags) - 1);

gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode, v8ArrayBufferAllocator());

« no previous file with comments | « no previous file | sky/examples/fps-counter.sky » ('j') | no next file with comments »