extensions/renderer/resources/guest_view/guest_view.js - Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view.js

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SurfaceView fix Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/app_view.js ('k') | extensions/renderer/resources/guest_view/guest_view_container.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/guest_view.js

diff --git a/extensions/renderer/resources/guest_view/guest_view.js b/extensions/renderer/resources/guest_view/guest_view.js

index 4e572a20ef19f9b735fac9552e47c314d6f7c09a..65e25281c9afb9e0ff8d50c36df9b26c6c26e1a8 100644

--- a/extensions/renderer/resources/guest_view/guest_view.js

+++ b/extensions/renderer/resources/guest_view/guest_view.js

@@ -186,8 +186,13 @@ GuestViewImpl.prototype.destroyImpl = function(callback) {

return;

}

+ // If this guest is attached, then detach it first.

+ if (!!this.internalInstanceId) {

+ GuestViewInternalNatives.DetachGuest(this.internalInstanceId);

+ }

GuestViewInternal.destroyGuest(this.id,

- this.handleCallback.bind(this, callback));

+ this.handleCallback.bind(this, callback));

paulmeyer 2015/01/13 20:06:33 Spacing; it looks like that extra space was a mist

Fady Samuel 2015/01/13 20:10:34 Done.

this.contentWindow = null;

this.id = 0;