Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.h

Issue 845363004: <webview>, <appview> and <extensionoptions> can run in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SurfaceView fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/app_view/app_view_guest.h
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.h b/extensions/browser/guest_view/app_view/app_view_guest.h
index e1bc1faf246439ac272e655c666e9ff488208f14..f745b4896410a910d67837cded65493e8aab40c0 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.h
+++ b/extensions/browser/guest_view/app_view/app_view_guest.h
@@ -53,12 +53,12 @@ class AppViewGuest : public GuestView<AppViewGuest>,
content::MediaStreamType type) override;
// GuestViewBase implementation.
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
+ bool CanRunInDetachedState() const override;
void CreateWebContents(const base::DictionaryValue& create_params,
const WebContentsCreatedCallback& callback) override;
- void DidAttachToEmbedder() override;
void DidInitialize(const base::DictionaryValue& create_params) override;
+ const char* GetAPINamespace() const override;
+ int GetTaskPrefix() const override;
// Sets the AppDelegate for this guest.
void SetAppDelegateForTest(AppDelegate* delegate);

Powered by Google App Engine
This is Rietveld 408576698