Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 845363002: Fix include directories in Windows GN build. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
Reviewers:
cjhopman, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include directories in Windows GN build. Committed: https://crrev.com/22779180d946d0e4d90a7ee3e6345992f2c0422b Cr-Commit-Position: refs/heads/master@{#311296}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/json_schema_api.gni View 1 chunk +1 line, -1 line 1 comment Download
M build/secondary/third_party/leveldatabase/BUILD.gn View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Slava Chigrin
https://codereview.chromium.org/845363002/diff/1/build/json_schema_api.gni File build/json_schema_api.gni (left): https://codereview.chromium.org/845363002/diff/1/build/json_schema_api.gni#oldcode74 build/json_schema_api.gni:74: include_dirs = [ target_gen_dir ] Here target_gen_dir is something ...
5 years, 11 months ago (2015-01-13 15:46:05 UTC) #2
scottmg
lgtm
5 years, 11 months ago (2015-01-13 17:36:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845363002/1
5 years, 11 months ago (2015-01-13 17:41:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 18:35:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 18:36:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22779180d946d0e4d90a7ee3e6345992f2c0422b
Cr-Commit-Position: refs/heads/master@{#311296}

Powered by Google App Engine
This is Rietveld 408576698