Source/platform/LengthFunctions.cpp - Issue 845313010: Allow Length::nonNanCalculatedValue to take a LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/LengthFunctions.cpp

Issue 845313010: Allow Length::nonNanCalculatedValue to take a LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add reftest Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/LengthFunctions.cpp

diff --git a/Source/platform/LengthFunctions.cpp b/Source/platform/LengthFunctions.cpp

index bb803dcf7cc36ac4533821e36445442115073abf..5894d0bb406376173c56cdd6f0282e87501b1ea4 100644

--- a/Source/platform/LengthFunctions.cpp

+++ b/Source/platform/LengthFunctions.cpp

@@ -71,7 +71,7 @@ LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue)

// Don't remove the extra cast to float. It is needed for rounding on 32-bit Intel machines that use the FPU stack.

return static_cast<float>(maximumValue * length.percent() / 100.0f);

case Calculated:

- return length.nonNanCalculatedValue(maximumValue);

+ return length.nonNanCalculatedValue(maximumValue.toFloat());

Julien - ping for review 2015/01/23 10:22:26 How about we just pass a LayoutUnit to the functio

case FillAvailable:

case Auto:

return 0;

« no previous file with comments | « Source/platform/Length.cpp ('k') | no next file » | no next file with comments »