Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: Source/platform/LengthFunctions.cpp

Issue 845313010: Allow Length::nonNanCalculatedValue to take a LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add reftest Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/Length.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/LengthFunctions.cpp
diff --git a/Source/platform/LengthFunctions.cpp b/Source/platform/LengthFunctions.cpp
index bb803dcf7cc36ac4533821e36445442115073abf..5894d0bb406376173c56cdd6f0282e87501b1ea4 100644
--- a/Source/platform/LengthFunctions.cpp
+++ b/Source/platform/LengthFunctions.cpp
@@ -71,7 +71,7 @@ LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue)
// Don't remove the extra cast to float. It is needed for rounding on 32-bit Intel machines that use the FPU stack.
return static_cast<float>(maximumValue * length.percent() / 100.0f);
case Calculated:
- return length.nonNanCalculatedValue(maximumValue);
+ return length.nonNanCalculatedValue(maximumValue.toFloat());
Julien - ping for review 2015/01/23 10:22:26 How about we just pass a LayoutUnit to the functio
case FillAvailable:
case Auto:
return 0;
« no previous file with comments | « Source/platform/Length.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698